fix(docs): Prevent trailing slash in example path from causing validation error - #1224
Open
sentry[bot] wants to merge 1 commit into
Open
fix(docs): Prevent trailing slash in example path from causing validation error#1224sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | f586af4 | Commit Preview URL Branch Preview URL |
Sep 05 2026, 11:04 PM |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where navigating to an examples index URL (e.g., /table/v8/docs/framework/react/examples) would result in a validation error.
The root cause was that when the
_splatparameter was empty (indicating the examples index), the path construction[framework, params._splat].join('/')would produce a trailing slash (e.g., "react/"). This trailing slash then caused therepoPathSchemavalidator infetchRepoDirectoryContentsto reject the path, leading to the observed error.The fix involves adding
.filter(Boolean)to the path construction:[framework, params._splat].filter(Boolean).join('/')This ensures that empty segments (like an empty
_splat) are filtered out before joining, preventing the creation of a trailing slash and allowing the path to pass validation.Fixes TANSTACK-COM-3G1
This PR was automatically generated by Sentry. You can adjust this setting at any time.