Remove read-pkg and write-package dependencies - #302
Open
bcomnes wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 34012808916Coverage increased (+0.3%) to 94.52%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
bcomnes
commented
Sep 6, 2026
bcomnes
marked this pull request as ready for review
September 6, 2026 04:54
Owner
Author
|
Need to see if the vendored versions behave the same or if we need to port more features over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write-packagewith a small local dependency updater used by--eject.read-pkgdependency and reuse the CLI's existing JSON reader for the package type and dependency versions.write-packageanddeepmerge-tsproduction dependency chain.read-pkgprovides normalized metadata and enhanced JSON errors, but these eject lookups do not need metadata normalization.No new reader abstraction or replacement dependency is introduced.
Validation
npm testpasses, including lint, Node tests, Playwright, installed-check, and TypeScript.--version, and--help.read-pkg,write-package, ordeepmerge-tsentries.npm audit --omit=devreports zero vulnerabilities for that installation.Fixes #293.