Slice source text instead of copying it line by line for outlining

[xperiandri]

Description

The editor's block structure built the sourceLines array for Structure.getOutliningRanges by calling ToString() on every line, allocating a fresh string for the whole file on each outlining pass, that is once per keystroke.

getOutliningRanges now takes ReadOnlyMemory<char>[] and the editor slices the already materialized source text once through a new SourceText.GetLinesAsMemory() helper. Inside the function, comment detection trims and classifies lines over spans instead of building trimmed strings, and comment groups track line numbers only, since only the first and last lines of a group are ever read back to compute the fold's columns.

ReadOnlySpanCharExtensions in illib mirrors the existing ordinal String helpers so span call sites read the same way.

This is a breaking change for FSharp.Compiler.Service consumers that call getOutliningRanges with a string[]; the migration is Array.map (fun line -> line.AsMemory()).

Fixes # (no issue)

Checklist

• Test cases added: the existing StructureTests (39 cases) exercise every fold kind through the new signature; the public surface area baseline is updated.
• Performance benchmarks added in case of performance changes: posted as a comment below. One outlining pass over a 13.6k-line file drops from 5.3 ms / 4.4 MB to 0.9 ms / 1.0 MB.
• Release notes entry updated: docs/release-notes/.FSharp.Compiler.Service/11.0.100.md, Breaking Changes.

🤖 Generated with Claude Code

[github-actions]

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
`src/Compiler`	docs/release-notes/.FSharp.Compiler.Service/11.0.100.md
`vsintegration/src`	docs/release-notes/.VisualStudio/18.vNext.md

[xperiandri]

Benchmark

BenchmarkDotNet, both versions of the changed code copied verbatim into a standalone harness (the compiler-internal helpers they use are internal, so the harness redefines the two one-line StartsWithOrdinal shims). before is ServiceStructure.fs at a29233c, after is this branch. The ScopeRange/range construction is stubbed identically on both sides so it does not skew the comparison, and [<GlobalSetup>] asserts both scanners find byte-identical comment blocks before any measurement runs.

Inputs are two real files from this repo: ServiceStructure.fs (1,107 lines) and CheckExpressions.fs (13,653 lines).

BenchmarkDotNet v0.15.4, Windows 11 (10.0.26200.9278)
AMD Ryzen 9 5980HS, 1 CPU, 16 logical and 8 physical cores
.NET SDK 10.0.400, .NET 10.0.11, X64 RyuJIT x86-64-v3

Step	File	Before	After	Time	Alloc before	Alloc after
Build line array	ServiceStructure.fs	15.6 us	3.5 us	4.4x	122 KB	17 KB
Comment scan	ServiceStructure.fs	77.9 us	43.3 us	1.8x	180 KB	54 KB
Build + scan	ServiceStructure.fs	124.3 us	53.8 us	2.3x	302 KB	71 KB
Build line array	CheckExpressions.fs	1,923 us	102 us	18.8x	1,753 KB	213 KB
Comment scan	CheckExpressions.fs	1,364 us	444 us	3.1x	2,645 KB	780 KB
Build + scan	CheckExpressions.fs	5,328 us	930 us	5.7x	4,399 KB	993 KB

"Build + scan" is what one outlining pass pays outside the AST walk, and the editor pays it per keystroke. On the large file that is 4.4 MB of garbage per pass before, 1.0 MB after, a 77% reduction; on the small file 76%.

Where the allocations went:

• Line array. ToString() per line copied every line of the file. Slicing the already-materialized text allocates only the array of ReadOnlyMemory<char> structs. What is left in the "after" column is that array.
• Comment scan. TrimStart() per line allocated a trimmed copy of every line just to test two prefixes; the span version trims in place. Comment groups also stored (int * string) tuples per line, now int only.

Variance is high on the multi-modal rows (the harness reports bimodal distributions on the scan benchmarks, and the full-pass rows carry a wide StdDev), so treat the time ratios as order-of-magnitude rather than precise. The allocation numbers are exact and are the substance of the change.

Two caveats worth stating plainly:

• Measured on .NET 10. FSharp.Compiler.Service ships netstandard2.0, and the editor caller runs on .NET Framework 4.7.2, where ReadOnlyMemory/ReadOnlySpan come from the System.Memory package. No ArrayPool is involved on this path, so the relative picture should hold, but I have not measured the desktop runtime.
• BenchmarkDotNet's header prints [Host] ... DEBUG. That is the known false positive for F# Release builds; DebuggableAttribute.IsJITOptimizerDisabled on the harness assembly is false.

[github-actions]

🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Restore
Affects-Build-Infra: adds PackageReference in test .fsproj
Affects-Restore: new System.Memory package ref changes restore graph

Generated by PR Tooling Safety Check · opus46 3.7M · ◷

[T-Gro]

🤖🕵️ These span overloads return a slice-relative index. The string sibling at line 110 and String.IndexOf(value, startIndex) return an absolute one:

str.Slice(startIndex).IndexOf(value, StringComparison.Ordinal)   // off by startIndex

A caller ported from the string path gets a column too small by startIndex, silently. They're also unused (ServiceStructure.fs calls none) yet add public surface. Delete the startIndex overloads, or add startIndex back to the result.

[xperiandri]

Good catch — deleted the four startIndex/count overloads in c9fbf5a.

Correcting the result would have taken more than adding startIndex back: IndexOf returns -1 for "not found", so the fix would need to preserve that separately from a real hit at offset 0. Since nothing calls them, deleting is the honest option — what remains is what ServiceStructure.fs actually uses.

Build clean, StructureTests 84/84.

[xperiandri]

Correction to my previous reply — the overloads are back in 793ffee, fixed rather than deleted. That is the better half of your suggestion; I shouldn't have reached for deletion.

They now report a position in the span they were handed, not in the slice they searched:

let i = str.Slice(startIndex).IndexOf(value, StringComparison.Ordinal)
if i < 0 then i else i + startIndex

The if is what keeps a miss at -1 instead of turning it into startIndex - 1. Checked each overload against its String counterpart — match after the start index, match exactly at it, match at index 0, no match, and a count window too short to contain the value — all six agree.

Build clean, StructureTests 84/84.